Skip to content

refactor: split DOM bindings into focused feature modules#270

Open
jderochervlk wants to merge 22 commits into
mainfrom
vlk/base
Open

refactor: split DOM bindings into focused feature modules#270
jderochervlk wants to merge 22 commits into
mainfrom
vlk/base

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

@jderochervlk jderochervlk commented May 20, 2026

Summary

Refactors the WebAPI bindings so the large DOM surface is split into smaller feature modules and directories. This moves APIs like HTML, CSSOM, Geometry, WebAnimations, Window, XPath, Location, Navigator, FileList, DOMException, and related types out of the core DOM folder and into more focused source roots.

Adds feature dependency metadata to rescript.json so the package can model relationships between split modules explicitly, while keeping public modules registered through the existing sources configuration.

Updates docs and design notes for the new module structure, including global singleton access, API surface guidance, and the docs generator path handling for newly split source directories.

// this is how it was before this PR, you had to get the value and pass it to the module and function
let before = Dom.crypto->Crypto.randomUUID

// this is how it works now
let after = Crypto.randomUUID()

Testing

  • npm run format:check
  • npm run build
  • npm test
  • npm run build:docs
  • GitHub Actions CI is passing on the latest PR commit (49420e4).

@jderochervlk jderochervlk marked this pull request as draft May 20, 2026 14:23
@jderochervlk
Copy link
Copy Markdown
Collaborator Author

@codex

@jderochervlk jderochervlk marked this pull request as ready for review May 30, 2026 15:37
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49420e4362

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/WebCrypto/Crypto.res Outdated
@jderochervlk jderochervlk marked this pull request as draft May 30, 2026 15:38
@jderochervlk jderochervlk changed the title refactor: move DOM file out of base folder refactor: split DOM bindings into focused feature modules May 30, 2026
@jderochervlk jderochervlk marked this pull request as ready for review May 30, 2026 15:38
@jderochervlk
Copy link
Copy Markdown
Collaborator Author

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c526dd58cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/WebCrypto/Crypto.res Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant